alex/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-02-21 01:40:19 +10:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.1.2090: Last buffer not freed with EXITFREE

Browse Source 
Problem:  Last buffer not freed with EXITFREE (after 9.1.2087).
Solution: Free the last buffer when inside free_all_mem()
          (zeertzjq).

This isn't really a memory leak, as the last buffer's memory is still
reachable via pointers like firstbuf and lastbuf. But it's possible that
this may cause false ASAN warnings in the future, which is what EXITFREE
is supposed to prevent.

closes: vim/vim#19194

6c118afeaa
(cherry picked from commit 960cba7b3b)
This commit is contained in:
zeertzjq
2026-01-17 18:35:41 +08:00
committed by github-actions[bot]
parent 0cc15be15d
commit d052d22979
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/nvim/buffer.c
View File

@@ -694,15 +694,20 @@ bool close_buffer(win_T *win, buf_T *buf, int action, bool abort_if_last, bool i
// Autocommands may have opened or closed windows for this buffer.
// Decrement the count for the close we do here.
// Don't decrement b_nwindows if the buffer wasn't displayed in any window
// before calling buf_freeall(),
// before calling buf_freeall().
if (nwindows > 0 && buf->b_nwindows > 0) {
buf->b_nwindows--;
}
// Remove the buffer from the list.
// Do not wipe out the buffer if it is used in a window, or if autocommands
// wiped out all other buffers.
if (wipe_buf && buf->b_nwindows <= 0 && (buf->b_prev != NULL || buf->b_next != NULL)) {
// wiped out all other buffers (unless when inside free_all_mem() where all
// buffers need to be freed and autocommands are blocked).
if (wipe_buf && buf->b_nwindows <= 0 && (buf->b_prev != NULL || buf->b_next != NULL
#if defined(EXITFREE)
|| entered_free_all_mem
#endif
)) {
if (clear_w_buf) {
win->w_buffer = NULL;
}