cfg: warn on quotes

copyparty/__main__.py

@@ -477,6 +477,21 @@ def expand_cfg(argv) -> list[str]:
     return argv
 
 
+def quotecheck(al):
+    for zs1, zco in vars(al).items():
+        zsl = [u(x) for x in zco] if isinstance(zco, list) else [u(zco)]
+        for zs2 in zsl:
+            zs2 = zs2.strip()
+            zs3 = zs2.strip("\"'")
+            if zs2 == zs3 or len(zs2) - len(zs3) < 2:
+                continue
+            if al.c:
+                t = "found the following global-config:   %s: %s\n values should not be quoted; did you mean:   %s: %s"
+            else:
+                t = 'found the following config-option:  "--%s=%s"\n values should not be quoted; did you mean:  "--%s=%s"'
+            warn(t % (zs1, zs2, zs1, zs3))
+
+
 def sighandler(sig: Optional[int] = None, frame: Optional[FrameType] = None) -> None:
     msg = [""] * 5
     for th in threading.enumerate():
@@ -2138,6 +2153,8 @@ def main(argv: Optional[list[str]] = None) -> None:
     except:
         sys.exit(1)
 
+    quotecheck(al)
+
     if al.chdir:
         os.chdir(al.chdir)
 

copyparty/authsrv.py

@@ -1442,7 +1442,7 @@ class AuthSrv(object):
                     if "=" in zs:
                         t = "WARNING: found an option named [%s] in your [global] config; did you mean to say [%s: %s] instead?"
                         zs1, zs2 = zs.split("=", 1)
-                        self.log(t % (zs, zs1, zs2), 3)
+                        self.log(t % (zs, zs1, zs2), 1)
                     if za is True:
                         self._e("└─argument [{}]".format(zs))
                     else:
@@ -1917,7 +1917,7 @@ class AuthSrv(object):
             vol.all_vps.sort(key=lambda x: len(x[0]), reverse=True)
             vol.root = vfs
 
-        zs = "du_iwho ls_q_m neversymlink"
+        zs = "du_iwho emb_all ls_q_m neversymlink"
         k_ign = set(zs.split())
         for vol in vfs.all_vols.values():
             unknown_flags = set()