From fac7c10eb8357cd569ff2020bea1600a14d6203a Mon Sep 17 00:00:00 2001 From: "neovim-backports[bot]" <175700243+neovim-backports[bot]@users.noreply.github.com> Date: Tue, 18 Nov 2025 21:56:26 -0800 Subject: [PATCH] fix(windows): set manifest resource ID to 1 in nvim.rc for MinGW (#36611) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fix(windows): wrong RT_MANIFEST ID in nvim.rc #36406 Problem: Starting Nvim on MinGW fails: https://github.com/msys2/MINGW-packages/issues/25140 Unknown system error -1："C:\msys64\ucrt64\bin\nvim.exe"Failed to start Nvim server! Solution: On Windows, the main application manifest should use resource ID 1 (RT_MANIFEST). Update `nvim.rc` to use `1 RT_MANIFEST nvim.manifest` instead of `2`, ensuring the manifest is correctly embedded and recognized by the system. ID = 1 is for executable files (.exe) ID = 2 is for DLLs (/DLL) From MSVC docs: "Use a value of 2 for a DLL to enable it to specify private dependencies." https://learn.microsoft.com/en-us/cpp/build/reference/manifest-create-side-by-side-assembly-manifest (cherry picked from commit 2c04ae9fcc9c9a70a7336d98e469ab6a5d97c6cc) Co-authored-by: SquallATF --- src/nvim/os/nvim.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nvim/os/nvim.rc b/src/nvim/os/nvim.rc index e838c93c16..74a34d382b 100644 --- a/src/nvim/os/nvim.rc +++ b/src/nvim/os/nvim.rc @@ -1,2 +1,2 @@ #include "winuser.h" -2 RT_MANIFEST nvim.manifest +1 RT_MANIFEST nvim.manifest