alex/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-02-21 09:50:19 +10:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.1.2055: Division by zero in :file after failing to wipe buffer (#37268)

Browse Source 
Problem:  Division by zero in :file after failing to wipe buffer
          (after 8.2.4631).
Solution: Still call buf_clear_file() when failing to wipe buffer
          (zeertzjq).

closes: vim/vim#19088

1aa5ca4ecb
(cherry picked from commit 97bfc0c99b)
This commit is contained in:
zeertzjq
2026-01-06 20:08:24 +08:00
committed by github-actions[bot]
parent cae3c838a7
commit f96e401b7e
2 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/nvim/buffer.c
View File

@@ -698,14 +698,11 @@ bool close_buffer(win_T *win, buf_T *buf, int action, bool abort_if_last, bool i
}
// Remove the buffer from the list.
if (wipe_buf) {
// Do not wipe out the buffer if it is used in a window.
if (wipe_buf && buf->b_nwindows <= 0) {
if (clear_w_buf) {
win->w_buffer = NULL;
}
// Do not wipe out the buffer if it is used in a window.
if (buf->b_nwindows > 0) {
return true;
}
FOR_ALL_TAB_WINDOWS(tp, wp) {
mark_forget_file(wp, buf->b_fnum);
}

25
test/old/testdir/test_autocmd.vim
View File

@@ -3376,7 +3376,7 @@ func Test_BufReadPre_changebuf()
close!
endfunc
" Test for BufWipeouti autocmd changing the current buffer when reading a file
" Test for BufWipeout autocmd changing the current buffer when reading a file
" in an empty buffer with 'f' flag in 'cpo'
func Test_BufDelete_changebuf()
new
@@ -3662,6 +3662,29 @@ func Test_bufwipeout_changes_window()
%bwipe!
endfunc
func Test_autocmd_prevent_buf_wipe()
" Xa must be the first buffer so that win_close_othertab() puts it in
" another window, which causes wiping the buffer to fail.
%bwipe!
file Xa
call setline(1, 'foo')
setlocal bufhidden=wipe
tabnew Xb
setlocal bufhidden=wipe
autocmd BufUnload Xa ++once ++nested tabonly
autocmd BufWinLeave Xb ++once tabnext
tabfirst
edit! Xc
call assert_equal('Xc', bufname('%'))
tabnext
call assert_equal('Xa', bufname('%'))
call assert_equal("\n\"Xa\" --No lines in buffer--", execute('file'))
%bwipe!
endfunc
func Test_v_event_readonly()
autocmd CompleteChanged * let v:event.width = 0
call assert_fails("normal! i\<C-X>\<C-V>", 'E46:')