From 272e04178060841e1bfda535de6f31825985ffef Mon Sep 17 00:00:00 2001 From: bfredl Date: Tue, 20 May 2025 11:21:52 +0200 Subject: [PATCH] fix(tests): don't surpress stderr output This is a diabolical anti-pattern and is hiding errors which exist currently in unittests. Also we want to see _where_ in the process stderr was emitted, stashing it away at the end erases important context. --- cmake/RunTests.cmake | 6 ------ 1 file changed, 6 deletions(-) diff --git a/cmake/RunTests.cmake b/cmake/RunTests.cmake index fc4c2c587a..6d123060b6 100644 --- a/cmake/RunTests.cmake +++ b/cmake/RunTests.cmake @@ -78,7 +78,6 @@ execute_process( ${TEST_PATH} TIMEOUT $ENV{TEST_TIMEOUT} WORKING_DIRECTORY ${WORKING_DIR} - ERROR_VARIABLE err RESULT_VARIABLE res ${EXTRA_ARGS}) @@ -87,11 +86,6 @@ file(REMOVE_RECURSE ${RM_FILES}) if(res) message(STATUS "Tests exited non-zero: ${res}") - if("${err}" STREQUAL "") - message(STATUS "No output to stderr.") - else() - message(STATUS "Output to stderr:\n${err}") - endif() # Dump the logfile on CI (if not displayed and moved already). if(CI_BUILD)