Update install hooks to respect XYZ_BINARY env vars

- All install hooks now respect their respective XYZ_BINARY env vars
  (e.g., WGET_BINARY, CHROME_BINARY, YTDLP_BINARY, etc.)
- Support both absolute paths (/usr/bin/wget2) and binary names (wget2)
- Dynamic bin_name used in Dependency JSONL output
- Updated 11 install hooks to follow the new pattern
- Mark checklist items as complete in TODO_hook_architecture.md
This commit is contained in:
Claude
2025-12-27 10:12:45 +00:00
parent 8c846b7d1c
commit e3ba599812
12 changed files with 339 additions and 85 deletions

View File

@@ -1,25 +1,39 @@
#!/usr/bin/env python3
"""
Validation hook for papers-dl.
Install hook for papers-dl.
Runs at crawl start to verify papers-dl binary is available.
Outputs JSONL for InstalledBinary and Machine config updates.
Respects PAPERSDL_BINARY env var for custom binary paths.
"""
import os
import sys
import json
from pathlib import Path
def find_papersdl() -> dict | None:
"""Find papers-dl binary."""
"""Find papers-dl binary, respecting PAPERSDL_BINARY env var."""
try:
from abx_pkg import Binary, PipProvider, EnvProvider
binary = Binary(name='papers-dl', binproviders=[PipProvider(), EnvProvider()])
# Check if user has configured a custom binary
configured_binary = os.environ.get('PAPERSDL_BINARY', '').strip()
if configured_binary:
if '/' in configured_binary:
bin_name = Path(configured_binary).name
else:
bin_name = configured_binary
else:
bin_name = 'papers-dl'
binary = Binary(name=bin_name, binproviders=[PipProvider(), EnvProvider()])
loaded = binary.load()
if loaded and loaded.abspath:
return {
'name': 'papers-dl',
'name': bin_name,
'abspath': str(loaded.abspath),
'version': str(loaded.version) if loaded.version else None,
'sha256': loaded.sha256 if hasattr(loaded, 'sha256') else None,
@@ -32,6 +46,15 @@ def find_papersdl() -> dict | None:
def main():
# Determine binary name from config
configured_binary = os.environ.get('PAPERSDL_BINARY', '').strip()
if configured_binary and '/' in configured_binary:
bin_name = Path(configured_binary).name
elif configured_binary:
bin_name = configured_binary
else:
bin_name = 'papers-dl'
# Check for papers-dl (required)
papersdl_result = find_papersdl()
@@ -65,10 +88,10 @@ def main():
else:
print(json.dumps({
'type': 'Dependency',
'bin_name': 'papers-dl',
'bin_name': bin_name,
'bin_providers': 'pip,env',
}))
missing_deps.append('papers-dl')
missing_deps.append(bin_name)
if missing_deps:
print(f"Missing dependencies: {', '.join(missing_deps)}", file=sys.stderr)