add overrides options to binproviders

archivebox/plugins/readability/on_Crawl__00_validate_readability.py

@@ -15,43 +15,12 @@ import subprocess
 from pathlib import Path
 
 
-def get_binary_version(abspath: str) -> str | None:
-    """Get version string from binary."""
-    try:
-        result = subprocess.run(
-            [abspath, '--version'],
-            capture_output=True,
-            text=True,
-            timeout=5,
-        )
-        if result.returncode == 0 and result.stdout:
-            first_line = result.stdout.strip().split('\n')[0]
-            return first_line[:64]
-    except Exception:
-        pass
-    return None
-
-
-def get_binary_hash(abspath: str) -> str | None:
-    """Get SHA256 hash of binary."""
-    try:
-        with open(abspath, 'rb') as f:
-            return hashlib.sha256(f.read()).hexdigest()
-    except Exception:
-        return None
-
-
 def find_readability() -> dict | None:
     """Find readability-extractor binary."""
     try:
         from abx_pkg import Binary, NpmProvider, EnvProvider
 
-        class ReadabilityBinary(Binary):
-            name: str = 'readability-extractor'
-            binproviders_supported = [NpmProvider(), EnvProvider()]
-            overrides: dict = {'npm': {'packages': ['github:ArchiveBox/readability-extractor']}}
-
-        binary = ReadabilityBinary()
+        binary = Binary(name='readability-extractor', binproviders=[NpmProvider(), EnvProvider()])
         loaded = binary.load()
         if loaded and loaded.abspath:
             return {
@@ -72,8 +41,8 @@ def find_readability() -> dict | None:
         return {
             'name': 'readability-extractor',
             'abspath': abspath,
-            'version': get_binary_version(abspath),
-            'sha256': get_binary_hash(abspath),
+            'version': None,
+            'sha256': None,
             'binprovider': 'env',
         }
 
@@ -110,10 +79,14 @@ def main():
 
         sys.exit(0)
     else:
+        # readability-extractor is installed from GitHub
         print(json.dumps({
             'type': 'Dependency',
             'bin_name': 'readability-extractor',
             'bin_providers': 'npm,env',
+            'overrides': {
+                'npm': {'packages': ['github:ArchiveBox/readability-extractor']}
+            }
         }))
         print(f"readability-extractor binary not found", file=sys.stderr)
         sys.exit(1)