Fix PR review comments: service flags, DATA_DIR, version pinning, upgrade safety

- Remove --setup flag from systemd service and CI (not valid in 0.9.x)
- Remove release triggers from debian/homebrew workflows (handled by release.yml)
- Fix brew post_install to set DATA_DIR so it initializes in var/archivebox
- Add PATH export to deb wrapper script for bundled console scripts
- Remove pip install fallback in install.sh (strict version pinning)
- Guard preremove.sh cleanup to only run on remove/purge, not upgrade
- Initialize SDIST_URL/SDIST_SHA256 in build_brew.sh (nounset safety)
- Pin awalsh128/cache-apt-pkgs-action to v1.6.0 (supply chain safety)

https://claude.ai/code/session_01Vx1EsNrNySgsc8Y67dGzCn
This commit is contained in:
Claude
2026-03-15 03:12:15 +00:00
parent 16090944c4
commit 7c7a9ee599
8 changed files with 37 additions and 34 deletions

View File

@@ -11,8 +11,7 @@ on:
- 'bin/release_brew.sh'
- '.github/workflows/homebrew.yml'
- 'pyproject.toml'
release:
types: [published]
# release trigger is handled by release.yml to avoid double-runs
permissions:
contents: read
@@ -49,7 +48,7 @@ jobs:
- name: Install build dependencies (Linux)
if: runner.os == 'Linux'
uses: awalsh128/cache-apt-pkgs-action@latest
uses: awalsh128/cache-apt-pkgs-action@v1.6.0
with:
packages: build-essential python3-dev python3-setuptools libssl-dev libldap2-dev libsasl2-dev zlib1g-dev libatomic1
version: 1.0
@@ -108,7 +107,8 @@ ${RESOURCES}
end
def post_install
system bin/"archivebox", "install", "--binproviders", "pip,npm"
(var/"archivebox").mkpath
system({ "DATA_DIR" => var/"archivebox" }, bin/"archivebox", "install", "--binproviders", "pip,npm")
end
service do
@@ -162,7 +162,7 @@ RUBY
- name: Test archivebox init
run: |
mkdir -p /tmp/archivebox-test && cd /tmp/archivebox-test
archivebox init --install
archivebox init
- name: Test archivebox status
run: |
@@ -274,7 +274,8 @@ ${RESOURCES}
end
def post_install
system bin/"archivebox", "install", "--binproviders", "pip,npm"
(var/"archivebox").mkpath
system({ "DATA_DIR" => var/"archivebox" }, bin/"archivebox", "install", "--binproviders", "pip,npm")
end
service do