mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-06 07:47:53 +10:00
Fix PR review comments: version check, runtime deps, CI test deps, release guard
- install.sh: Replace awk float comparison with integer major/minor check so Python 3.9 is correctly rejected as < 3.13 - nfpm.yaml: Add git/curl/wget as recommends so users have basic archiving tools out of the box without needing `archivebox install` - debian.yml: Restore git/curl/wget in CI smoke test to match what the package recommends, instead of relying on runner preinstalls - debian.yml: Guard release upload to skip gracefully when no GitHub Release exists (fixes workflow_dispatch failures) https://claude.ai/code/session_01Vx1EsNrNySgsc8Y67dGzCn
This commit is contained in:
@@ -13,8 +13,10 @@ if command -v python3.13 >/dev/null 2>&1; then
|
||||
PYTHON="python3.13"
|
||||
elif command -v python3 >/dev/null 2>&1; then
|
||||
PYTHON="python3"
|
||||
PY_VER="$("$PYTHON" -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')"
|
||||
if [ "$(echo "$PY_VER 3.13" | awk '{print ($1 >= $2)}')" != "1" ]; then
|
||||
PY_MAJOR="$("$PYTHON" -c 'import sys; print(sys.version_info.major)')"
|
||||
PY_MINOR="$("$PYTHON" -c 'import sys; print(sys.version_info.minor)')"
|
||||
if [ "$PY_MAJOR" -lt 3 ] || { [ "$PY_MAJOR" -eq 3 ] && [ "$PY_MINOR" -lt 13 ]; }; then
|
||||
PY_VER="${PY_MAJOR}.${PY_MINOR}"
|
||||
echo "[!] Error: ArchiveBox requires Python >= 3.13, but found Python $PY_VER"
|
||||
echo " Install python3.13: sudo apt install python3.13 python3.13-venv"
|
||||
exit 1
|
||||
|
||||
@@ -28,6 +28,14 @@ depends:
|
||||
# All other runtime deps (node, chrome, yt-dlp, etc.) are installed on-demand
|
||||
# by `archivebox install` and should NOT be declared as package dependencies.
|
||||
|
||||
recommends:
|
||||
# Common utilities used by archivebox extractors. Declared as recommends
|
||||
# (not depends) so dpkg doesn't hard-fail if they're missing, but apt
|
||||
# installs them by default so users have a working baseline out of the box.
|
||||
- git
|
||||
- curl
|
||||
- wget
|
||||
|
||||
contents:
|
||||
# Wrapper script for /usr/bin/archivebox
|
||||
- src: pkg/debian/archivebox
|
||||
|
||||
Reference in New Issue
Block a user