Address remaining PR review comments

- Pin cache-apt-pkgs-action to commit SHA for supply-chain safety
- Fix Homebrew post_install to use with_env block instead of env hash
  in system() call (idiomatic Homebrew pattern)
- Add clarifying comments to service file, preremove.sh, and nfpm.yaml
  explaining user/group creation, directory ownership, and upgrade handling

https://claude.ai/code/session_01Vx1EsNrNySgsc8Y67dGzCn
This commit is contained in:
Claude
2026-03-15 03:39:33 +00:00
parent 2845e4350a
commit 68fea71933
6 changed files with 18 additions and 7 deletions

View File

@@ -1,3 +1,6 @@
# The archivebox user/group and /var/lib/archivebox directory are created by
# postinstall.sh (which runs after dpkg unpacks the package contents).
[Unit]
Description=ArchiveBox Web Archiving Server
After=network.target

View File

@@ -55,7 +55,7 @@ contents:
file_info:
mode: 0644
# Create data directory
# Create data directory (unpacked as root; postinstall.sh chowns to archivebox user)
- dst: /var/lib/archivebox
type: dir
file_info:

View File

@@ -2,7 +2,9 @@
# preremove script for archivebox .deb package
set -e
# Only clean up on full removal, not during upgrade
# Only clean up on full removal, not during upgrade.
# dpkg passes "$1" as "remove", "purge", or "upgrade" — we skip cleanup on
# upgrade so the venv and service persist across package version bumps.
if [ "$1" = "remove" ] || [ "$1" = "purge" ]; then
# Stop the service if running
if command -v systemctl >/dev/null 2>&1 && [ -d /run/systemd/system ]; then