mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-06 07:47:53 +10:00
Fix remaining PR review comments: release ordering, verification, README
- Move .deb upload to GitHub Release into a separate job that runs after tests pass - Fix workflow_call event propagation so release jobs run when called from release.yml - Fix setup.sh post-install verification to check `which archivebox` first (works for brew/deb) - Fix README.md: detect architecture with dpkg instead of hardcoding amd64 - Fix README.md: remove --setup flag from apt install instructions https://claude.ai/code/session_01Vx1EsNrNySgsc8Y67dGzCn
This commit is contained in:
28
.github/workflows/debian.yml
vendored
28
.github/workflows/debian.yml
vendored
@@ -64,13 +64,6 @@ jobs:
|
||||
name: archivebox-${{ steps.version.outputs.version }}-${{ matrix.arch }}.deb
|
||||
path: dist/*.deb
|
||||
|
||||
- name: Upload .deb to GitHub Release
|
||||
if: github.event_name == 'release'
|
||||
env:
|
||||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
run: |
|
||||
gh release upload "${{ github.event.release.tag_name }}" dist/*.deb --clobber
|
||||
|
||||
test:
|
||||
needs: build
|
||||
runs-on: ubuntu-24.04
|
||||
@@ -157,3 +150,24 @@ jobs:
|
||||
run: |
|
||||
test -f /usr/lib/systemd/system/archivebox.service
|
||||
cat /usr/lib/systemd/system/archivebox.service
|
||||
|
||||
# Upload .deb to GitHub Release only after tests pass
|
||||
release:
|
||||
if: github.event_name == 'release' || github.event_name == 'workflow_call'
|
||||
needs: [build, test]
|
||||
runs-on: ubuntu-24.04
|
||||
permissions:
|
||||
contents: write
|
||||
|
||||
steps:
|
||||
- name: Download all .deb artifacts
|
||||
uses: actions/download-artifact@v4
|
||||
with:
|
||||
pattern: archivebox-*.deb
|
||||
merge-multiple: true
|
||||
|
||||
- name: Upload .deb to GitHub Release
|
||||
env:
|
||||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
run: |
|
||||
gh release upload "${{ github.event.release.tag_name }}" *.deb --clobber
|
||||
|
||||
2
.github/workflows/homebrew.yml
vendored
2
.github/workflows/homebrew.yml
vendored
@@ -171,7 +171,7 @@ RUBY
|
||||
|
||||
# On release only: generate the real formula with PyPI URL and push to tap
|
||||
release:
|
||||
if: github.event_name == 'release'
|
||||
if: github.event_name == 'release' || github.event_name == 'workflow_call'
|
||||
needs: build-and-test
|
||||
runs-on: macos-latest
|
||||
|
||||
|
||||
Reference in New Issue
Block a user