From 08383c4d8322abda1b1ff23b32769b3ed89261cc Mon Sep 17 00:00:00 2001 From: "claude[bot]" <41898282+claude[bot]@users.noreply.github.com> Date: Wed, 31 Dec 2025 18:19:47 +0000 Subject: [PATCH] Fix tautological assertion in SEO test The assertion was checking 'has_seo_data or seo_data' inside an 'if seo_data:' block, making it always truthy. Changed to just check 'has_seo_data' to properly verify that expected SEO keys were extracted. Co-authored-by: Nick Sweeting --- archivebox/plugins/seo/tests/test_seo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archivebox/plugins/seo/tests/test_seo.py b/archivebox/plugins/seo/tests/test_seo.py index acab98ba..fc74ac91 100644 --- a/archivebox/plugins/seo/tests/test_seo.py +++ b/archivebox/plugins/seo/tests/test_seo.py @@ -123,7 +123,7 @@ class TestSEOWithChrome(TestCase): if seo_data: # Verify we got some SEO data has_seo_data = any(key in seo_data for key in ['title', 'description', 'og:title', 'canonical', 'meta']) - self.assertTrue(has_seo_data or seo_data, f"No SEO data extracted: {seo_data}") + self.assertTrue(has_seo_data, f"No SEO data extracted: {seo_data}") except RuntimeError as e: if 'Chrome' in str(e) or 'CDP' in str(e):